Incorrect typing of resolve type CalendarResponse in async.fromURL

[jamie--stewart]

👋 Hello,

We use this library for downloading ICS files from user-supplied URLs.

In real-world usage we are seeing a number of responses that do not match the typing of CalendarResponse (Record<string, CalendarComponent>).

An example is:

{
  version: '2.0',
  calscale: 'GREGORIAN',
  prodid: 'SANITISED room calendar',
  '20220813T082405Z - 25326@ord5': {
    type: 'VEVENT',
    params: [],
    uid: '20220813T082405Z - 25326@ord5',
    start: 2022-08-12T23:00:00.000Z,
    datetype: 'date-time',
    end: 2024-04-03T23:00:00.000Z,
    dtstamp: 2022-08-13T08:24:05.000Z { tz: 'Etc/UTC' },
    summary: 'RoomId: SANITISED - Room not available'
  }

You can see above a number of string values ahead of the VEVENT object.

The typing for CalendarResponse would appear to be more accurately Record<string, CalendarComponent | string>.

I'd be happy to look at raising a PR for this, if you agree that it is an issue?

[Apollon77]

Or would it also be an option to declate the type as partial?

[jamie--stewart]

Hi @Apollon77, I'm not 100% sure what you mean there. I'm saying that the value of the object's keys are sometimes string, sometimes CalendarComponent, not that they may be undefined?

[Apollon77]

ahh kk

[Apollon77]

I think @jens-maus is happy about a PR :-)