Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Finish upgrade as a separate step #37

Open
markspolakovs opened this issue Aug 8, 2018 · 2 comments
Open

[Feature Request] Finish upgrade as a separate step #37

markspolakovs opened this issue Aug 8, 2018 · 2 comments

Comments

@markspolakovs
Copy link

Thank you for creating this plugin! It has saved me a lot of time.

One feature I think would be useful is to finish the upgrade as a separate step.

Use Case: deploy the service, run some tests, then finish the upgrade if they pass (and rollback if they fail)

@EslamElHusseiny
Copy link

+1

@sicrossley
Copy link

I've created a simple "Confirm" step in my forked repo. I'll add "Rollback" too, and then I'll submit a PR. Please have a look and let me know what you think.
https://github.com/sicrossley/rancher-plugin/tree/confirm-upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants