Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLabConnectionConfig.does not check if Gitlab Connection is unique #1670

Open
arturrekawek opened this issue Jul 24, 2024 · 0 comments
Open
Labels
bug For changelog: Minor bug. Will be listed after features

Comments

@arturrekawek
Copy link

Jenkins and plugins versions report

Environment
Paste the output here

What Operating System are you using (both controller, and any agents involved in the problem)?

https://javadoc.jenkins.io/plugin/gitlab-plugin/com/dabsquared/gitlabjenkins/connection/GitLabConnectionConfig.html#addConnection(com.dabsquared.gitlabjenkins.connection.GitLabConnection)

Any Jenkins LTS version

Reproduction steps

run few times with Groovy
gitLabConnectionConfig.addConnection(newConnection)
it does not check if newConnection is unique

Expected Results

this function should work as
https://javadoc.jenkins.io/plugin/gitlab-branch-source/io/jenkins/plugins/gitlabserverconfig/servers/GitLabServers.html#addServer(io.jenkins.plugins.gitlabserverconfig.servers.GitLabServer)

Actual Results

Currently you can create multeiple connection with same id (name)
It is not acceptable

Anything else?

No

Are you interested in contributing a fix?

Currently no

@arturrekawek arturrekawek added the bug For changelog: Minor bug. Will be listed after features label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features
Projects
None yet
Development

No branches or pull requests

1 participant