Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org members are not trusted in Pull Requests #1377

Open
infl00p opened this issue Sep 24, 2021 · 0 comments
Open

Org members are not trusted in Pull Requests #1377

infl00p opened this issue Sep 24, 2021 · 0 comments

Comments

@infl00p
Copy link

infl00p commented Sep 24, 2021

Hello,
I have a 3 month old installation of Jenkins-X hosted on gcp, which I haven't configured much, I only imported my github organization's repositories.
The problem is that since 1 week ago my org members are not trusted by lighthouse schedulers, but external collaborators are trusted!

In the logs I see:
{"timestamp":"2021-09-24T08:18:03.021670071Z","message":"User \"infl00p" is a member of the trusted org \"todo\" - false","severity":"INFO","context":{}}
The trusted_org was left unchanged (todo), which is logical to return false. But according to the source code in pkg/plugins/trigger/trigger.go it should not have gone to this code path, because I'm a collaborator (my team is admins on this repository) and I'm a member and owner of my organization. And we are not using the review-required scheduler, only the in-repo

I did change the helm charts repositories 2 weeks ago, to github registry, as instructed, but I haven't done any other change to jenkin-x. Lighthouse chart went from 1.1.42 to 1.1.51.

Could it be a Github API change? Because what I did as a workaround is add my username to all the organizations repositories as a collaborator. I mean not just my team, but my username also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant