JX Build Controller Fails to start- could not read Username No such device or address jx-build-controller

[taraoumx]

Using and - EKS/Bitbucket combo , the controller fails to start. I verified that the secret-git token is mounted properly in the file system yet this exception occurs :

fatal: could not read Username for 'https://XXXXXXXXX.com': No such device or address
jx-build-controller
FATAL: failed to get cluster requirements: failed to clone cluster git repo https://XXXXXXXXX.com/scm/project/jx-config.git: failed to clone repositoryhttps://XXXXXXXXX.com/scm/project/jx-config.git to directory: /tmp/jx-git-782291392: failed to run 'git clone https://XXXXXXXXX.com/scm/project/jx-config.git /tmp/jx-git-782291392' command in directory '/tmp', output: 'Cloning into '/tmp/jx-git-782291392'...

[syndicut]

I believe it's a bug here: https://github.com/jenkins-x/jx-helpers/blob/6eb9664b305cfe79adad52bd7ad65811347359ca/pkg/gitclient/credentialhelper/git_credential.go#L219
bitbucket can generate tokens with special symbols and credentials writer does not urlencode strings