Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot install properly on Rails 5.2.1, uses depreciated "before_filter" #84

Open
casbross opened this issue Sep 27, 2018 · 3 comments
Open

Comments

@casbross
Copy link

This creates a devise_permitted_parameters.rb file that uses the depreciated before_filter action. I had to edit the file to be before_action instead of before_filter for the installation to work.

@hermanomark
Copy link

Have you make it work??
I did the same thing added this line of code in application_controller.rb

before_action :authenticate_tenant!

and then change devise_permitted_parameters.rb to before_action.

when I run the
rails g milia:install --org_email=''

It forces the devise_permitted_parameters.rb to use before_filter again and returns the error.

@hermanomark
Copy link

I've made it work lol, when running
rails g milia:install --org_email=''
it will ask you to overwrite devise_permitted_paramters.rb
don't type Y instead type N to not overwrite the before_action in devise_permitted_paramters.rb

Hope this helps someone!

@casbross
Copy link
Author

casbross commented Oct 9, 2018

I edited the file after doing this install, but that should work as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants