Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #4

Open
10 tasks
robi-y opened this issue May 10, 2016 · 0 comments
Open
10 tasks

Improvements #4

robi-y opened this issue May 10, 2016 · 0 comments

Comments

@robi-y
Copy link
Contributor

robi-y commented May 10, 2016 •
edited
Loading

  • Readme: Installation of pre-req: node.js, use the issues for improvements
  • Packaje json: more complete so no warnings on npm install (remove --watch? disturbs doing commits)
  • Add codecov integration (also for PRs) and maybe also code-climate
  • .gitignoe - also ignore temp files, eg., file.js~ (by gedit?), also intelij
    's .idea folder
  • start from the 2nd feature which is more basic?
  • start from a simpler test? e.g. empty map (and first returning null) and maybe supply the existing test as ignored/skipped
  • 7 commits are not enough
  • name of ex and 1st function collide - refactor, e.g., to CrowdMap (also the class name which can be thought as a hash
  • Maybe provide list of suggested test cases (take more control of the process)
  • Ask for a reflection section added to the Readme? at the end?
matanan added a commit to matanan/tdd-nodejs-find-a-person that referenced this issue May 15, 2016
@matanan
GREEN: Test jce-il#4 fixed
835ef40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robi-y