Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite to use Discord webhooks instead of Slack-compatible Discord webhooks #55

Open
jb3 opened this issue Apr 23, 2020 · 6 comments
Open

Comments

@jb3
Copy link
Owner

jb3 commented Apr 23, 2020

As said in the title, currently we use the /slack endpoint since when I created this library this is what I was most knowledgable with. We should now migrate this to use Discord webhook formatting.

@Exitare
Copy link
Contributor

Exitare commented Apr 23, 2020

What would be the best way to start this ?
I assume we would use
https://discordjs.guide/popular-topics/embeds.html#embed-preview

@jb3
Copy link
Owner Author

jb3 commented Apr 23, 2020

Not necessarily, the Discord docs are sufficient for this.

@Exitare
Copy link
Contributor

Exitare commented Apr 23, 2020

@jb3
Copy link
Owner Author

jb3 commented Apr 23, 2020

https://discordapp.com/developers/docs/resources/channel#embed-object this will be the most useful.

@MrZillaGold
Copy link

Does it make sense to rewrite the library if can use Discord.js and its WebhookClient.
WebhookClient also supports working with the inner Discord.js MessageEmbed class.

Yes, the library will be less in size, but it seems to me that this is not a particularly weighty argument.

@jb3
Copy link
Owner Author

jb3 commented Nov 13, 2020

I think it makes sense to rewrite it, yes.

This library serves as an independent way to work with webhooks without discord.js, it gets used and has thousands of downloads on NPM.

We should continue development of this library irrelevant of the external situation with webhook libraries on NPM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants