Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Books listed by Genre page formatting #55

Open
michelliebel opened this issue Sep 24, 2017 · 3 comments
Open

Books listed by Genre page formatting #55

michelliebel opened this issue Sep 24, 2017 · 3 comments
Labels

Comments

@michelliebel
Copy link

Hi! My books list page sorted by genre is formatting wonky. I can fix it, but it would help me to see which template or what-have-you is causing it to grab all the meta info and display it inline with the description of the book.

Screengrab attached.

Thanks!
Michelle
example

@jazzsequence
Copy link
Owner

That's a weird issue I haven't seen before. Generally, what's happening is we're using the the_contentfilter to insert the various bits of Book Review meta data (like reading level, genre, etc) at the bottom of the content. (Here's the filter: https://github.com/jazzsequence/book-review-library/blob/master/views/public.php#L46 and here's what it does: https://github.com/jazzsequence/book-review-library/blob/master/views/public.php#L119-L211) The times where I've seen weird stuff like that (not that issue specifically but similar-ish things) is when there's another plugin that's also filtering the_content and the two things clash with each other.

If you look at the second link to the source code, you can see there's a lot of markup and ids/classes in there. Or there should be, at any rate. That's there so you can manipulate the appearance however you want with CSS. My suggestion would be to make sure (since I can't see the markup on your page) that those div tags and elements are there, and have the right classes, and use CSS to fix up the appearance of your archive pages. This is as opposed to going through all your plugins (or your theme) to try to figure out what it is that's causing the issue (although you could do that, too). My guess is that in another theme, or with one of your plugins deactivated, it would look okay.

@michelliebel
Copy link
Author

Hi! No joy on testing for a problem with another theme/plugin.

Also no span tags were inserted, so it's metadata that's getting inserted straight. I checked the plugins and the themes, but no luck. It's got to be in one of the excerpted styles because there's an ellipses at the end...

@jazzsequence
Copy link
Owner

Thanks for checking and reporting the issue. I am currently trying to rewrite the entire plugin and also ultimately add unit tests, so I will get to it but it might take a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants