Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_instance precision #133

Open
jornedeblaere opened this issue Aug 21, 2019 · 5 comments
Open

to_instance precision #133

jornedeblaere opened this issue Aug 21, 2019 · 5 comments

Comments

@jornedeblaere
Copy link

Due to the update of v2.4.1 to v2.5.0 the signature of the Geometry.init has changed by adding the precision parameter. As we work with precision=7 this causes some troubles with the base.to_instance() function as here no precision parameter is provided and thus in the parsing precision 6 is used. Although this can be overcome by injecting the precission in the input feature.geometry proptery, I think it would be a nice improvement if this precision parameter could be added in the to_instance() call as well.

@mbway
Copy link

mbway commented Aug 22, 2019

in addition, it would be nice to either have some way of passing parameters from the load() and loads() functions to the geometry objects, such as precision. If the parameters were exposed to to_instance() then a partially applied call could be passed as the object_hook parameter to load() but this isn't very user friendly.

@klausmyrseth
Copy link

We have the same problem, we need to be able to set presicion on to_instance aswell. We are working with high precision devices also in research and need to be able to override the default also in to_presision.

So +1

@aj-hitchins
Copy link

You can set the defaults as per this response until there is a fix:
#135 (comment)

@hhowe29
Copy link

hhowe29 commented Jul 1, 2021

+1. Working with precision AG data where the GPS coordinates were corrected with RTK down to 1 inch accuracy. Need a clean way to override the default precision of 6. The workaround is getting us by.

@rayrrr
Copy link
Member

rayrrr commented May 7, 2022

This is fixed on the master branch thanks to #177. DEFAULT_PRECISION can now be set at the package level. This feature will become available in the next release, sometime this month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants