Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug. Why height=0? Not displayed background slideshow. #83

Open
NKozlov opened this issue May 29, 2015 · 17 comments
Open

Bug. Why height=0? Not displayed background slideshow. #83

NKozlov opened this issue May 29, 2015 · 17 comments

Comments

@NKozlov
Copy link

NKozlov commented May 29, 2015

I have a project where I use vegas. U can see demo here: http://nkozlov.github.io/wedding-page/ .
Sometimes (rarely) when you refresh the page (press F5 or ctrl+R) slide show is not displayed, because for some reason, the height of the container becomes equal to 0. I absolutely can not understand what the problem is. I think that the problem in the vegas. Can u solve it?

@NKozlov
Copy link
Author

NKozlov commented May 29, 2015

@NKozlov NKozlov changed the title Bug. Why height=0? I can't see background slideshow. Bug. Why height=0? Not displayed background slideshow. May 29, 2015
@jaysalvat
Copy link
Owner

Hello,

The height of your container is in %. It can't work.
Vegas can't create the height of the Vegas inner container properly with %.

The question is why does it work sometimes.

@NKozlov
Copy link
Author

NKozlov commented May 29, 2015

I do not quite understand what kind of container u tell me. Is it "photoBox-container"?
How, then, to use the Vegas to make a slideshow in not-full screen, but on the inner container, and the height should be responsible (%)?

For example:

<div class="container">
    <div class="header">
        Title header
    </div>
    <div class="here_i_want_use_vegas_height_65%">
    </div>
    <div class="other_info">
    </div>
</div>

@jaysalvat
Copy link
Owner

I'm afraid it's impossible with height in %.
Sorry.

@NKozlov
Copy link
Author

NKozlov commented May 30, 2015

Can you enhancement the vegas?

@jaysalvat
Copy link
Owner

I will investigate but I'm afraid not.

Try to force your css height with !important;

@jaysalvat
Copy link
Owner

So?
Does it work with forcing css height?

@bennyzen
Copy link

bennyzen commented Jun 8, 2015

same here. .vegas-slide gets always a height of 0px. i followed your suggestion and set the height of the container to 600px forcing it as !important. all slides keep getting a height of 0.

the funny part here is that it works before using 'grunt build'. as soon as the source gets uglified / minified the height of the slides becomes 0px. no error or warning is output to console and all images get loaded properly.

edit: just rechecked anything and found out that the css was not included by the build-process. sorry, mea culpa.

@jaysalvat
Copy link
Owner

Thanks for your feedbacks.

Can I close the issue now?

@NKozlov
Copy link
Author

NKozlov commented Jun 10, 2015

% height does not work stable. Only fixed height for container. If u can fixed this issue in the future thats good! Thx!

@bennyzen
Copy link

why don't you try to use something like 50vh as height? it's proportional and it works. at least for me it did the trick.

@rsmith4321
Copy link

I don't think that is an issue its prob a misunderstanding of css. You need
to use vh like 100vh will fill the viewport.

On Wednesday, June 10, 2015, Nikita Kozlov [email protected] wrote:

% height does not work stable. Only fixed height for container. If u can
fixed this issue in the future thats good! Thx!


Reply to this email directly or view it on GitHub
#83 (comment).


Ryan Smith
http://www.myrtlebeachphotography.org

@rsmith4321
Copy link

The plugin works perfectly well you need to check out the examples and
figure out what you are doing wrong. Just copy the example.

On Wednesday, July 1, 2015, Slava [email protected] wrote:

.vegas-slide-inner is at 0 as well.


Reply to this email directly or view it on GitHub
#83 (comment).


Ryan Smith
http://www.myrtlebeachphotography.org

@apurvpatel
Copy link

Hi
not rotate slide

@apurvpatel
Copy link

untitled

@apurvpatel
Copy link

untitled

@apurvpatel
Copy link

Vegas slider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants