Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text/html gzip etag exception #150

Open
CoolLifeLaugh opened this issue Jun 1, 2018 · 1 comment
Open

text/html gzip etag exception #150

CoolLifeLaugh opened this issue Jun 1, 2018 · 1 comment

Comments

@CoolLifeLaugh
Copy link

when nginx transfer , text/html type , etag is deleted. but
image
null point exception

@mjmbischoff
Copy link

mjmbischoff commented Jun 28, 2018

Pull request fixes it for getting the objects as inputstream, since getting the expected etag doesn't throw any exceptions. It will fail with a nullpointer if a MD5 can be calculated on the client, but the server doesn't report any (because it's stripped out by some proxy/loadbalancer/intermediate).

It's really annoying that the openstack swift designers decided to reuse the HTTP etag field which has slightly different semantics.

I'm not entirely sure what behavior we want if we can actually compose an md5. Given we don't have an etag and we can calculate an MD5: should it fail or silently ignore the check?

@ferrys do you have a particular opinion on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants