-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for php_version variable #6
Comments
A good idea and is actually implemented in this fork: |
@im-mortal, @E-VANCE: This is nice. Though having so many forks will end up in siloing these improvements. |
@strarsis Totally agree, this should be consolidated... @im-mortal Would you be willing to carry on? If so then I'll create a PR. I'd maintain the project also, just let me know. |
@strarsis, @E-VANCE, thank you for replying. @strarsis, of course I can merge @E-VANCE's latest changes into my fork as I think using @E-VANCE, still, I would gladly redirect to your fork if you wish to maintain it, or invite you as a collaborator if you think my fork should be up to date, or just merge your PRs as they go. I'm good either way. |
That would be great! Also because not all forked repositories have the issue tracker enabled. |
@im-mortal @strarsis |
@E-VANCE Thank you! I've sent you an invite for collaboration. |
In the meantime, I've opened the pull request myself: Due to some additional changes in the fork (which don't quite belong to the scope of the pull request), I welcome any discussion there. |
Trellis now uses a variable
php_version
for defining the PHP version: roots/trellis@5f398b2Note: The PHP version variable can be interpolated like this:
{{ php_version }}
Example of its usage in Trellis: https://github.com/roots/trellis/search?q=%7B%7B+php_version+%7D%7D
It would be therefore nice if
trellis-redis
also uses this variable, as intrellis-redis/handlers/main.yml
Line 19 in 1538a4d
The text was updated successfully, but these errors were encountered: