Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: when using the dependency from Jitpack, the translations are gone #109

Open
AndroidDeveloperLB opened this issue Jun 1, 2022 · 2 comments

Comments

@AndroidDeveloperLB
Copy link

It seems as if what's on Jitpack is older than what's on the repository, or something.
Steps:

  1. Run the sample as it is
  2. Change device locale to Hebrew ("עברית")
  3. Run the sample again and check what happens for the "Color picker with alpha". Notice that the texts have changed.
  4. Now change in the gradle file, to this:
//  implementation project(':library')
implementation 'com.jaredrummler:colorpicker:1.1.0'
  1. Try what's on step 3.

The bug is that it is in English.

See here:

studio64_WY7J4MSMkg.mp4

ColorPicker.zip

Workaround: use Jitpack instead, to reach the latest commit:

implementation 'com.github.jaredrummler:ColorPicker:eb76c92f53'

See attached project with all 3 options tested.
ColorPicker.zip

Also, BTW, if you don't want the icon of the preferences, this is a better way instead of using the app-compat PreferenceGroupAdapter class:
https://stackoverflow.com/a/51568782/878126

@AndroidDeveloperLB
Copy link
Author

I actually prefer that we could set the strings ourselves, to let translators handle it.

@AndroidDeveloperLB
Copy link
Author

AndroidDeveloperLB commented Jun 1, 2022

Here, created a way to customize them all:
https://github.com/AndroidDeveloperLB/ColorPicker
#110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant