Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI bug when using searchable and indexable together #643

Open
cbetta opened this issue Mar 6, 2015 · 8 comments
Open

UI bug when using searchable and indexable together #643

cbetta opened this issue Mar 6, 2015 · 8 comments
Labels

Comments

@cbetta
Copy link

cbetta commented Mar 6, 2015

I've been trying to use searchable and indexable together and it seems to have a UI bug. The index pushes the cells, and the search box, to the left.

ios simulator screen shot 6 mar 2015 18 26 46

@jamonholmgren
Copy link
Owner

I'm pretty sure this is a consequence of hard-coding the 320 width. TODO: assign @cbetta to fix this. ;)

@markrickert
Copy link
Contributor

👍 This has been needing to be fixed for a while now. Should be an easy fix.

@cbetta
Copy link
Author

cbetta commented Mar 6, 2015

Lol, will see if I can dig at it. Anyone got a clue how to hotfix this for now?

@cbetta
Copy link
Author

cbetta commented Mar 6, 2015

From what I can tell I should be able to do something like:

searchable frame: CGRectMake(0, 0, 350, 44)

to change the frame size, am I right?

@markrickert
Copy link
Contributor

easiest way to check is to clone this repos, then change the gemfile in your project to:

gem "ProMotion", path: "../ProMotion"

then run bundle in your project and any changes you make to the local cloned repos will be compiled and built into your app.

@cbetta
Copy link
Author

cbetta commented Mar 7, 2015

@markrickert so been trying to fix this but rather lost. Pretty new to all this so not too sure if I'm digging at this right. Regardless of the value of the frame (I clone the repo locally and am using that as the gem in my project) the index just pushes all cells and the searchbar to the left.

@cbetta
Copy link
Author

cbetta commented Mar 7, 2015

To reclarify: it's pushing both the cells AND the search box.

@jamonholmgren
Copy link
Owner

@cbetta I'll look at this next week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants