Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeds don't use inline ActiveJob adapter like default seeds.rb file does #84

Open
zeptonaut opened this issue Feb 18, 2020 · 0 comments

Comments

@zeptonaut
Copy link

Since this patch, Rails seeds have been configured to always run with the inline ActiveJob adapter instead of the async one. Unfortunately, the way that this was implemented is incompatible with seed bank (it looks directly at the db/seeds.rb file to determine if the replacement should be made).

One concrete ramification that this async -> inline replacement has is that it forces any images stored in ActiveStorage to have their heights and widths analyzed immediately instead of on a background worker. This background analysis doesn't work correctly during seed population and causes the heights and widths to instead never be calculated.

(I discovered this issue with Seedbank when trying to figure out why our seed images' aspect ratios were always nil, when they were working fine in production.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant