Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error handling in inner functions #9

Open
jakewilliami opened this issue Aug 29, 2022 · 2 comments
Open

Better error handling in inner functions #9

jakewilliami opened this issue Aug 29, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@jakewilliami
Copy link
Owner

We should handle errors better in internal functions. E.g., see SystemError and Base.IOError. See also how realpath handles non-existent paths.

The worst case scenario is that we seg fault, as we are passing around pointers within C calls. Let's try to avoid this (at the very least) at all costs.
@jakewilliami
Copy link
Owner Author

Part of this is better checking of output in all of the ccalls we make. E.g., here.

jakewilliami added a commit that referenced this issue Aug 29, 2022
@jakewilliami
Throw error if path does not exist
5aa2ad0 
Addresses #9.  This will hopefully avoid any problems that arise in
any internal functions used.  Note that further error handling should
be implemented, as, for example, checking for package or bundle still
seg faults when you give it the root directory.
jakewilliami added a commit that referenced this issue Aug 29, 2022
@jakewilliami
Check that MDItemCreate succeeded
750cca4 
Addresses #9
jakewilliami added a commit that referenced this issue Aug 29, 2022
@jakewilliami
Check that CFStringCreateWithCString succeeded
ddcbd9b 
Addresses #9
jakewilliami added a commit that referenced this issue Aug 29, 2022
@jakewilliami
Check that MDItemCopyAttribute succeeded
4848dab 
Addresses #9
@jakewilliami jakewilliami added the enhancement New feature or request label Sep 11, 2022
jakewilliami added a commit that referenced this issue Sep 11, 2022
@jakewilliami
Check that jl_lstat succeeded
5ce791e 
Ensure that the lstat call succeeded based on its return code.  The
expected return code is 0, otherwise it errored.

Addresses #9.
@jakewilliami
Copy link
Owner Author

Another aspect to this is ensuring that we check the expected return code (e.g. 5ce791e).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jakewilliami