Properly Lex String Literals #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -218,6 +224,46 @@ int real_lex(Lexer *l, Token *t) { | |||
| } | |||
|
|
|||
| // TODO - parse character or string literal | |||
| int c; | |||
| int *type; | |||
There was a problem hiding this comment.
I think it might be clearer if we used named constants here instead of integer literals for the values of type. Also, is there a reason for the usage of an int*?
| @@ -83,6 +83,12 @@ int is_valid_numeric_or_id_char(char c) { | |||
| return isalnum(c) || (c == '_') || (c == '.'); | |||
| } | |||
|
|
|||
| int is_valid_string_char(char c, int* type) { | |||
There was a problem hiding this comment.
What is type used for here? It doesn't seem to be used in the logic of the function and isn't accessible outside of it.
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not fully functional yet but placing for review to see if anyone has any issues with how the strings/chars are read in. I want to make sure I didn't misinterpret anything. Also, note backslashes are not implemented yet.