Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated curry methods on Function[N] #274

Open
johnmcclean opened this issue Dec 9, 2016 · 5 comments
Open

Remove the deprecated curry methods on Function[N] #274

johnmcclean opened this issue Dec 9, 2016 · 5 comments

Comments

@johnmcclean
Copy link
Contributor

I can submit a PR if you like.

I think one curry() method per Function type that returns a chain of single parameter functions would be useful here instead.

@lukaseder
Copy link
Member

I can submit a PR if you like.

Glad you asked. Don't :) Because this code is generated. The real code (generator code) is not in this repository.

The deprecation was introduced with #216, because the functions don't actually curry, they apply partially.

Do you need curry at your side?

@johnmcclean
Copy link
Contributor Author

Yeah, I'd like a curry method on them directly. I'm going extend them (to add in useful methods related to the types in cyclops), a curry method would be very useful (could be added in either library) - but the deprecated curry methods will be confusing in that case.

By the way - what do you think of this issue - aol/cyclops#422 . Do you think we could add such a match method directly to the Tuples in jOOλ?

@lukaseder
Copy link
Member

OK, thanks for the feedback. I guess we can remove them, as jOOλ hasn't reached 1.0 yet.

Hmm, I'd prefer not to put too many things in the Tuple[N] types prematurely. For instance, your suggested match() method lists [N] predicates per tuple. But are you sure those predicates will always operate on only one attribute?

@lukaseder
Copy link
Member

Anyway, I think we should discuss a potential new match() method in a new issue...

@lukaseder lukaseder changed the title Is it possible to remove the deprecated curry methods on Function[0..n]? Remove the deprecated curry methods on Function[N] Dec 14, 2016
@lukaseder
Copy link
Member

It might still be a bit early to remove the methods. I'll postpone this to the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants