Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expires date on offerset #78

Open
Zarquan opened this issue Oct 28, 2024 · 1 comment
Open

Remove expires date on offerset #78

Zarquan opened this issue Oct 28, 2024 · 1 comment

Comments

@Zarquan
Copy link
Member

Zarquan commented Oct 28, 2024

Having the expires property on an OfferSet make it hard to have aggregating and/or proxy services that combine offers from different platforms.

@Zarquan Zarquan changed the title Remove state and expires on offerset Remove expires date on offerset Oct 28, 2024
@Zarquan
Copy link
Member Author

Zarquan commented Oct 28, 2024

Aggregating services can generate a calculated state from the combined state of the offers it contains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant