Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imDetector and fgmodel/appearance #1

Open
pv33 opened this issue Aug 11, 2020 · 6 comments
Open

imDetector and fgmodel/appearance #1

pv33 opened this issue Aug 11, 2020 · 6 comments
Labels
good first issue Good for newcomers

Comments

@pv33
Copy link
Member

pv33 commented Aug 11, 2020

translate these two classes over.

@pv33 pv33 added the good first issue Good for newcomers label Aug 11, 2020
@pv33 pv33 added this to the Neon target tracking milestone Aug 11, 2020
@pv33
Copy link
Member Author

pv33 commented Aug 11, 2020

Make sure to include doxygen formatting that tracks the formatting in the Matlab file.
Some things might need to change. We can discuss.

@ruinianxu
Copy link

@pv33
Dear Dr. Vela,

For imDetector, do you refer to the class named constblob? I can't find any classes named imDetector in that Matlab repo.

For fgmodel/appearance, I really have no idea which one you refer since according to the folder name, there is no one about foreground.

@pv33
Copy link
Member Author

pv33 commented Aug 15, 2020

@ruinianxu
This ivapy organization is the equivalent to ivaMatlibs but for python not Matlab. Everything you are asked to translate here has a direct analog in the detection repository of ivaMatlibs. It should be pretty straightforward.

You should figure out how to make the code look like a python package so that it gets called in the same way.

@ruinianxu
Copy link

ruinianxu commented Aug 19, 2020

  • transfer imDetector from Matlab to Python
  • transfer appearance from Matlab to Python
  • add doxygen format

@ruinianxu
Copy link

@pv33
Dear Dr. Vela,

I suppose I transferred most part of imDetector and appearance correctly but I have one concern.

For imDetector, since there is no detail about attributes preprocessor and postprocessor, I suppose they should be array with shape like 3x1 or something like that. Please confirm that.

I haven't added doxygen format and will do it later this week.

@pv33
Copy link
Member Author

pv33 commented Aug 20, 2020

They are located in the improcessor repository. none and basic are the ones to transfer. Put them in a package and remove the improcessor prefix, so that instantiation is now

improcessor.none and improcessor.basic

Not sure if we should have a top-level ivapy or ivalibs type of invocation. We can discuss some other time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants