[Question]: TypeScript types?

[vhesener]

Feel free to remove this issue, but I wasn't sure where to ask questions. I noticed there are no types in DefinitelyTyped. Have you heard of anyone that has created TS types for this API already? As a truly lazy dev, I'd like to reuse and recycle :)

[thisissami]

It's your lucky day! I just submitted a PR to DefinitelyTyped with type definitions for this library. DefinitelyTyped/DefinitelyTyped#44534

[vhesener]

Awesome! Yea I couldn't help myself and was playing around with this myself. I came up with basically the same thing, minus the tests. Thanks for the quick turnaround!

[thisissami]

@ivantsov - the team at DefinitelyTyped (the typescript definitions library) have a question about your intent with the current definition file in your repo (since it hasn't been published in NPM). Could you answer them? DefinitelyTyped/DefinitelyTyped#44534 (comment)

[ivantsov]

Hey @thisissami, TS file was added by this PR #6. It was a contribution from one of the users. I don't have any plans for adding TS support for this package, but would check a PR.

[EdmundasR]

@ivantsov the typing file is not present once installed - you can go to node_modules of redux-subscriber and the index.d.ts is not present neither in root or lib dirs.

edited: link to publishing npm module with type: https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html