This repository has been archived by the owner on Apr 14, 2020. It is now read-only.

Composing keyframes fundamentally doesn't work well #160

Open

itsdouges opened this issue Jul 29, 2019 · 0 comments

Labels

Owner

itsdouges commented Jul 29, 2019 •

edited

Loading

https://codesandbox.io/s/tw-04-elmo-complete-9ubiy

It ends up causing too many problems. Instead of trying to be clever to try and compose them - we should just have them in one component instead.

Move the code from both into a new component.
Remove docs for Scale and Translate components, and deprecate them

itsdouges added the issue: bug label

itsdouges changed the title ~~Composing scale/translate doesn't really work properly~~ Composing scale/translate was a bad idea

itsdouges changed the title ~~Composing scale/translate was a bad idea~~ Composing keyframes fundamentally doesn't work well

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.