Skip to content
This repository has been archived by the owner on Apr 14, 2020. It is now read-only.

Reshaping styling api could be better #131

Open
itsdouges opened this issue May 31, 2019 · 0 comments
Open

Reshaping styling api could be better #131

itsdouges opened this issue May 31, 2019 · 0 comments

Comments

@itsdouges
Copy link
Owner

itsdouges commented May 31, 2019

It was a mistake having all style props at the top level. If we look at a more standardised solution atm it would be via a theme prop, I guess? should it be a function? should it be an object? should it be style?

it is, at the end of the day, a style, but not all styles are allowed to pass through.

this can be done as a non-breaking change first, and then remove the other styles after. styles inside style prop take precedence.

<ReshapingContainer
  triggerKey={`${toggler.shown}`}
+  style={{ padding: '16px', maxWidth: '500px', margin: '0 auto' }}
-  padding="16px"
-  maxWidth="500px"
-  margin="0 auto"
/>
@itsdouges itsdouges changed the title Reshaping container should have styling under a theme prop Reshaping styling api could be better Jun 5, 2019
@itsdouges itsdouges mentioned this issue Jun 8, 2019
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant