Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Use classify-imports instead of isort for import classification #680

Open
sisp opened this issue May 30, 2023 · 1 comment
Open

Use classify-imports instead of isort for import classification #680

sisp opened this issue May 30, 2023 · 1 comment
Labels
core Related to things in mlem.core enhancement New feature or request

Comments

@sisp
Copy link

sisp commented May 30, 2023

I noticed that isort is used for classifying imports, which is something isort can do, but it's not isort's primary job. I wonder whether you've considered classify-imports which is a utility library that is also used in reorder-python-imports, which is an an alternative to isort that performs static import analysis. It might be a lighter and more tailored dependency to solve that problem. Just an idea. 😇

@aguschin
Copy link
Contributor

Hi @sisp! Thanks for a suggestion! @mike0sv was selecting isort for the purpose, and I'm not sure if he was considering anything else. We'll keep this in mind in case we'll need a better alternative.

@aguschin aguschin added enhancement New feature or request core Related to things in mlem.core labels Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core Related to things in mlem.core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants