You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Closesitchio#11
- Add only_files query param to /extract
- Rename some args and fields for clarity
- Analyzer now inspects file name, not bucket key
- Test extraction results with only_files
- Delete MusicAnalyzer and "contents" query param
hryx
added a commit
to hryx/zipserver
that referenced
this issue
Nov 29, 2022
Closesitchio#11
- Add only_files query param to /extract
- Test extraction results with only_files
Other details:
- Add Analyzer interface. Originally this was used to handle game and
music zips differently, but now only GameAnalyzer remains.
- Rename some args and fields for clarity
- Change some structs, namely removing ResourceSpec, which fragmented
concerns across domains a bit. Logic which affected outgoing headers was
consolidated under the GameAnalyzer implementation.
- Add optional Metadata field to API result JSON.
- Tests: Replaced assert.NoError() with require.NoError(). The latter stops
a test immediatly if the assertion fails, which prevents useless and
noisy panic traces in test output. No dependencies added, already part
of the testify module.
- Removed unnecessary struct literal type names when they can be inferred,
per linter.
- Log non-OK notification responses
hryx
linked a pull request
Nov 29, 2022
that will
close
this issue
Add new parameter to /extract that takes an array of files (json array encoded) that should be uploaded.
eg
["helo.mp3", "fjefjkef/efefjewf/wsejf/dog.ogg"]
The text was updated successfully, but these errors were encountered: