Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse sale appears as -100% instead of +100% #1713

Open
its-dave opened this issue Jan 2, 2025 · 2 comments
Open

Reverse sale appears as -100% instead of +100% #1713

its-dave opened this issue Jan 2, 2025 · 2 comments
Labels

Comments

@its-dave
Copy link

its-dave commented Jan 2, 2025

Describe the bug
Reverse sales where the creator is temporarily doubling the price are labeled with -100%

To Reproduce
View any reverse sale e.g. this

Expected behavior
Reverse sales should be labeled with +100%

Screenshots
Screenshot_20250102-111359_1

Smartphone:

  • OS: Android
  • Browser: Chrome 131, Firefox 133

Additional context
Doesn't seem to just be a visual bug, APIs seem to think that it's -100% too

@its-dave its-dave added the bug label Jan 2, 2025
@leafo
Copy link
Member

leafo commented Jan 13, 2025

It's written as "-100% off", which would be equivalent to "100% more"

@its-dave
Copy link
Author

OK, that seems kind of confusing when the sale page normally says -100% for a sale and 100% more for a reverse sale. Is it deliberately confusing as part of the "April Fools" theme of the reverse sales?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants