Challenge 1: Implementing the addRoute method

[AbhishekTimalsina]

class RouteNode {
  constructor() {
    this.children = new Map();
    this.handler = null;
  }
  add(path, isLastPath, handler) {
    let newNode = new RouteNode();
    this.children.set(path, newNode);

    if (isLastPath) newNode.handler = handler;
    return newNode;
  }
}

class TrieRouter {
  constructor() {
    this.root = new RouteNode();
  }
  addRoute(path, handler) {
    if (typeof path != "string" || typeof handler != "function") {
      throw new Error(
        "'path' should be of the type `string` and 'handler' should be of the type `function`"
      );
    }
    let segmentedPath = this.#normalizePath(path);

    let currentNode = this.root;
    for (let pathIndex = 0; pathIndex < segmentedPath.length; pathIndex++) {
      let currentPath = segmentedPath[pathIndex];
      let foundNode = currentNode.children.get(currentPath);

      if (foundNode) {
        currentNode = foundNode;
        if (pathIndex === segmentedPath.length - 1) {
          throw new Error("This route is already included");
        }
      } else {
        let insertedNode = currentNode.add(
          currentPath,
          pathIndex === segmentedPath.length - 1,
          handler
        );
        currentNode = insertedNode;
      }
    }
  }

  #normalizePath(path) {
    let splittedNormalizedPath = path.split("/").filter((path) => {
      if (!path) return;
      return path;
    });
    return splittedNormalizedPath;
  }
}

const trieRouter = new TrieRouter();
trieRouter.addRoute("/api/books/1", function () {
  console.log("The silence of the lambs");
});

[winterrdog]

Hi @AbhishekTimalsina,

I think you forgot to handle the case when a URL path does not starts with a slash.

I think you could handle it here:

#normalizePath(path) {
  let splittedNormalizedPath = path.split("/").filter((path) => {
    if (!path) return;
    return path;
  });
  return splittedNormalizedPath;
}