Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Updates check available #155

Open
GrakovNe opened this issue Sep 12, 2024 · 2 comments
Open

Make Updates check available #155

GrakovNe opened this issue Sep 12, 2024 · 2 comments

Comments

@GrakovNe
Copy link

I've come across the following code:

try:
    response = requests.request('GET', 'http://kz0q.com/daemon-releases', verify=False, timeout=10)
    response.raise_for_status()
except requests.exceptions.RequestException as exc:
    print_line('- getDaemonReleases() RQST exception=({})'.format(exc), error=True)
    error = True

It seems that this code triggers a network request on each execution. Unfortunately, this causes significant performance issues for my Raspberry Pi Zero, as it consumes considerable CPU and RAM to process these frequent checks. Additionally, it leads to unnecessary network traffic, which impacts my home network.

While the daemon performs its core functionality perfectly for monitoring, I am unable to use it in its current form due to these resource constraints.

To address this, I would kindly like to propose an enhancement: implement a more efficient update-checking mechanism that only checks for updates once a day or, for example, once every 100 runs.

If you agree with this solution, I would be happy to submit a pull request with an implementation.

Thank you for your time and consideration!

@bsimmo
Copy link

bsimmo commented Sep 14, 2024

There is a whole problem with this area of the code.
1st frequency of check cannot be changed (iirc)
2nd it cannot be turned off (see other issues)
3rd it fails and crashes the code if the server is offline (see other issues)
4th it should really check github for releases rather than rely on ironsheep to update his server.
5th probably something else.

I don't know how far any of this came, see other issues and if there are any pull requests.

This is only a nice to have function but does seem to cause the most problems with people.

If you know how to fix all of these, have a go I've not see ironside active on this project for a while thoughm

@bsimmo
Copy link

bsimmo commented Sep 14, 2024

Forgot to add, some month back a 1.9.x branch was being developed, see the history, but it has not come about yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants