Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

irods.test.query_test.TestQuery.test_files_query_case_sensitive's between test fails for mysql #600

Open
alanking opened this issue Aug 1, 2024 · 1 comment
Open

irods.test.query_test.TestQuery.test_files_query_case_sensitive's between test fails for mysql #600

alanking opened this issue Aug 1, 2024 · 1 comment
Labels
bug testing

Comments

@alanking
Copy link
Contributor

alanking commented Aug 1, 2024

This was first discovered in #597. See also: #597 (comment) and irods/irods#7930

We need to be able to detect the database type being used in the iRODS server and change the assertions based on that.
alanking added a commit to alanking/python-irodsclient that referenced this issue Aug 1, 2024
@alanking
[irods#600] Comment out test_files_query_case_sensitive BETWEEN tests
313fc2b 
The BETWEEN clause behaves differently for mysql (and mariadb, I assume)
than postgres, and the test_files_query_case_sensitive test assumes that
we are using postgres. In order to avoid this, the BETWEEN sub-tests have
been commented out until such a time as we can make meaningful assertions
about the case-sensitive query with a BETWEEN clause based on the flavor
of database being used by the connected iRODS server.
alanking added a commit that referenced this issue Aug 1, 2024
@alanking
[#600] Comment out test_files_query_case_sensitive BETWEEN tests
7af55af 
The BETWEEN clause behaves differently for mysql (and mariadb, I assume)
than postgres, and the test_files_query_case_sensitive test assumes that
we are using postgres. In order to avoid this, the BETWEEN sub-tests have
been commented out until such a time as we can make meaningful assertions
about the case-sensitive query with a BETWEEN clause based on the flavor
of database being used by the connected iRODS server.
@alanking alanking mentioned this issue Aug 1, 2024
Closed
@alanking
Copy link
Contributor Author

alanking commented Aug 1, 2024

This sub-test(ish) is now being skipped as of PR #601. A TODO linked to this issue has been left next to the code which needs to be fixed:

python-irodsclient/irods/test/query_test.py

Lines 181 to 184 in 7af55af

# BETWEEN tests
# TODO(#600): Uncomment these lines and/or make a new test when database flavor can be detected.
# The resultset for BETWEEN queries can differ from database to database.

@alanking alanking added the bug label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug testing
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alanking