Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving irods.test.helpers.make_session into irods.helpers #590

Open
alanking opened this issue Jul 23, 2024 · 6 comments
Open

Consider moving irods.test.helpers.make_session into irods.helpers #590

alanking opened this issue Jul 23, 2024 · 6 comments

Comments

@alanking
Copy link
Contributor

alanking commented Jul 23, 2024

It seems that this irods.test.helpers.make_session function has grown to be useful beyond just the tests. Should we move it into this module so that it can be used directly? If so, let's create an issue to look into that some other time (i.e. don't do it as part of this change). The existing version in irods.test.helpers can then call the new one with its existing default value(s) to minimize the blast radius.

Originally posted by @alanking in #589 (comment)

It may or may not be beneficial to do this, but I didn't want to lose the idea, so here's the issue. :)

@mstfdkmn
Copy link

FYI: I remember this #412 because waiting for an enhancement to use make_session easily where needed.

@alanking
Copy link
Contributor Author

@mstfdkmn - Good catch. Perhaps this can be closed as a duplicate of #412. Thoughts, @d-w-moore?

@d-w-moore
Copy link
Collaborator

d-w-moore commented Jul 24, 2024

Yes, this PR probably sets us on a particular path for addressing #412. As to what's the better name, irods.utility, irods.misc or irods.helpers, I don't know. I usually defer to the consensus. Have there been any other PR's around that attempt to establish a common space for utility functions and such?

@korydraughn
Copy link
Contributor

There's already an irods.session module. Why not put it in there?

from irods.session import make_session

@d-w-moore
Copy link
Collaborator

d-w-moore commented Jul 24, 2024

@korydraughn I'm ok with that. So then we keep #412 around for now, and consider whether it may or may not be addressed by the creation of irods.helpers.xml_mode and the namespace / package in which it resides?

@korydraughn
Copy link
Contributor

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants