Use get / get_ref for nlohmann::json objects passed as parameters with different types

[alanking]

• main
• 4-3-stable

---

All of the parameters seen in these code snippets are being implicitly cast from nlohmann::json objects to the respective types of the receiving parameters:

irods_capability_storage_tiering/src/main.cpp

Lines 761 to 772 in 4c759d6

	return apply_data_movement_policy(
	comm,
	plugin_instance_name,
	rule_obj["object-path"],
	rule_obj["user-name"],
	rule_obj["user-zone"],
	rule_obj["source-replica-number"],
	rule_obj["source-resource"],
	rule_obj["destination-resource"],
	rule_obj["preserve-replicas"],
	rule_obj["verification-type"]);
	});

irods_capability_storage_tiering/src/main.cpp

Lines 776 to 785 in 4c759d6

	return apply_tier_group_metadata_policy(
	st,
	rule_obj["group-name"],
	rule_obj["object-path"],
	rule_obj["user-name"],
	rule_obj["user-zone"],
	rule_obj["source-replica-number"],
	rule_obj["source-resource"],
	rule_obj["destination-resource"]);
	});

These should be using the nlohmann::json::get or nlohmann::json::get_ref template functions with the explicit types specified.