Add error handling to proxy_connection

[alanking]

• main
• 4-3-stable

---

At least 3 things can go wrong in this function and none of them are being handled:

irods_capability_storage_tiering/include/irods/private/storage_tiering/proxy_connection.hpp

Lines 12 to 34 in 4c759d6

	auto make(const std::string clientUser = "", const std::string clientZone = "") -> rcComm_t*
	{
	rodsEnv env{};
	_getRodsEnv(env);
	conn = _rcConnect(
	env.rodsHost,
	env.rodsPort,
	env.rodsUserName,
	env.rodsZone,
	!clientUser.empty() ?
	clientUser.c_str() :
	env.rodsUserName,
	!clientZone.empty() ?
	clientZone.c_str() :
	env.rodsZone,
	&err_msg,
	0, 0);
	clientLogin(conn);
	return conn;
	} // make

Make sure error cases are being checked and handled appropriately.

[alanking]

Alternatively, as we move toward admin-only for all operations, we can probably just replace this entirely with client_connection and assume that the connection is privileged (i.e. use ADMIN_KW without checking authFlag in RcComm).

[korydraughn]

Agreed.