Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run clang-format on entire codebase #292

Open
alanking opened this issue Jan 10, 2025 · 1 comment
Open

Run clang-format on entire codebase #292

alanking opened this issue Jan 10, 2025 · 1 comment

Comments

@alanking
Copy link
Contributor

We should do this as part of the next "major" release.

If you're concerned about git-blame, the Black python formatter documentation introduced me to the nice concept of ignoring commits: https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revltrevgt

And there's even support in GitHub: https://docs.github.com/en/repositories/working-with-files/using-files/viewing-and-understanding-files#ignore-commits-in-the-blame-view

And here's the original documentation through which I discovered these things: https://black.readthedocs.io/en/stable/guides/introducing_black_to_your_project.html

Until then, we should update the .clang-format file to not use tabs so that we can actually use it.

@korydraughn
Copy link
Collaborator

Yes please do.

alanking added a commit to alanking/irods_capability_storage_tiering that referenced this issue Jan 15, 2025
Restore use of tabs before running clang-format on all the code.

AlignTrailingComments is false in irods/irods and is generally annoying,
so don't restore that.
alanking added a commit that referenced this issue Jan 15, 2025
Restore use of tabs before running clang-format on all the code.

AlignTrailingComments is false in irods/irods and is generally annoying,
so don't restore that.
alanking added a commit to alanking/irods_capability_storage_tiering that referenced this issue Jan 15, 2025
Restore use of tabs before running clang-format on all the code.

AlignTrailingComments is false in irods/irods and is generally annoying,
so don't restore that.
alanking added a commit that referenced this issue Jan 15, 2025
Restore use of tabs before running clang-format on all the code.

AlignTrailingComments is false in irods/irods and is generally annoying,
so don't restore that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants