-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replicas can be restaged to a higher (slower) tier #239
Comments
Looks like this check needs to be expanded to include data which is on a lower tier than the minimum restage tier: irods_capability_storage_tiering/storage_tiering.cpp Lines 803 to 807 in b50254b
|
Agreed. Check more scenarios, and return early. |
alanking
added a commit
to alanking/irods_capability_storage_tiering
that referenced
this issue
Dec 20, 2023
When a replica on a tier which is lower than the minimum restage tier is scheduled for restaging, it should not move to the minimum restage tier because that would entail restaging to a higher (slower) tier which defeats the purpose of a restage.
alanking
added a commit
to alanking/irods_capability_storage_tiering
that referenced
this issue
Dec 20, 2023
This commit gets the tier for the source resource and minimum restage tier and compares them before attempting a restage. If the source resource is in a tier that is lower than the minimum restage tier, the data migration for the restage should be skipped.
alanking
added a commit
that referenced
this issue
Dec 20, 2023
When a replica on a tier which is lower than the minimum restage tier is scheduled for restaging, it should not move to the minimum restage tier because that would entail restaging to a higher (slower) tier which defeats the purpose of a restage.
alanking
added a commit
that referenced
this issue
Dec 20, 2023
This commit gets the tier for the source resource and minimum restage tier and compares them before attempting a restage. If the source resource is in a tier that is lower than the minimum restage tier, the data migration for the restage should be skipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
iRODS Version, OS and Version
iRODS server: 4.3.1
Storage tiering plugin: 4.3.1
What did you try to do?
A test introduced in #234 revealed this issue. Here's the setup:
Have 3 resources which are configured as tiers in the same group:
Set
preserve_replicas
totrue
on ufs0.Set
minimum_restage_tier
totrue
on ufs1.iget -R ufs0
on the object.Expected behavior
After discussing with team, the expected behavior is for nothing to happen. The replica that was fetched is already on a lower (faster) tier than the minimum restage tier, so there is no benefit to restaging it to the higher (slower) tier.
Observed behavior (including steps to reproduce, if applicable)
Replica 3 appears on ufs1, restaged from ufs0.
The restaging logic needs to ensure that the minimum restage tier is lower than the tier from which the replica is being restaged.
The text was updated successfully, but these errors were encountered: