Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you edit a .csv file via 'preview', the content's format changes #293

Open
jefscheepers opened this issue Nov 23, 2021 · 1 comment
Open
Assignees
Labels
Milestone

Comments

@jefscheepers
Copy link

What did you try to do?

I uploaded a CSV file, and tried to edit one of the values via 'view info' > 'preview'.

Original data:

Year,Inflation (%)
2021,0.7
2020,2.1
2019,1.7
2018,0.2
2017,0.1
2016,0.5
2015,1
2014,2.1
2013,2.7
2012,3.1
2011,0.2

Changed to:

image

Then I clicked on 'save'.

What did you expect?
The contents would look as follows:

Year,Inflation (%)
2021,1.4
2020,2.1
2019,1.7
2018,0.2
2017,0.1
2016,0.5
2015,1
2014,2.1
2013,2.7
2012,3.1
2011,0.2

What happened?

The change seems applied, and I get an alert and green popup saying my changes have been successfully applied.
However, when I exit and reenter the preview tab, it cannot load the file (it seems to load indefinitely):
image

When I download the file, the format is now as follows:

data=2021%2C1.4+%0D%0A2020%2C2.1%0D%0A2019%2C1.7%0D%0A2018%2C0.2%0D%0A2017%2C0.1%0D%0A2016%2C0.5%0D%0A2015%2C1%0D%0A2014%2C2.1%0D%0A2013%2C2.7%0D%0A2012%2C3.1%0D%0A2011%2C0.2%0D%0A

Tested on Metalnx version 2.4.0 with iRODS 4.2.10.

@korydraughn korydraughn added this to the 2.6.0 milestone Nov 23, 2021
@trel trel modified the milestones: 2.6.0, 3.0.0 Apr 12, 2022
@korydraughn
Copy link
Contributor

Editing files via Metalnx feels out-of-scope.

Users are free to download, modify, and upload new versions of files without issue.

This feature should be removed.

@korydraughn korydraughn self-assigned this Sep 9, 2022
jefscheepers pushed a commit to kuleuven/iRODS-User-Training that referenced this issue Sep 12, 2022
File editing in Metalnx is not working in version 2.5.1
(the save button is missing), and this functionality will be cut
in the next version anyway (see irods-contrib/metalnx-web#293 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants