Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements: End of the week edition #27

Open
irfanbozkurt opened this issue Aug 25, 2023 · 0 comments
Open

Improvements: End of the week edition #27

irfanbozkurt opened this issue Aug 25, 2023 · 0 comments
Assignees

Comments

@irfanbozkurt
Copy link
Owner

irfanbozkurt commented Aug 25, 2023

Create a PR attempting to address the following:

  • Folder rearrangement
  • Further deconstruction into components
  • Reintroduces local storage cache for auto-detected assets to avoid extra API calls. Introduces a refresh button (with bad style) to 'force fetch'.
  • Thanks to the local storage, implements clear 'state transition functions' that facilitate switching between steps 1-2-3-4
    • From asset selection to hacked address selection is made possible
    • User can remove an 'unsignedTx' in the bundling phase and go back to asset selection, and their changes in the bundling phase will apply. For example, if they removed a transaction at this step, it will be removed in the previous step as well.
    • Adding a custom call was adding the call to the "assets" but didn't "select" the call as an "asset". As a result, user needed to both add the custom call and then select it. This PR corrects this behavior.
  • Check added for when hacked account and safe account are the same
  • Minor renamings
@irfanbozkurt irfanbozkurt self-assigned this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant