Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider characters limit on the comments #54

Open
ghost opened this issue Oct 25, 2018 · 2 comments
Open

Consider characters limit on the comments #54

ghost opened this issue Oct 25, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Oct 25, 2018

We may need to consider some options regarding the comments, since we're working on a sidebar level we need to encourage the users to keep comments really short almost as 'tweet', this will help keep objectivity on each comment and provide a great scan for the discussion/thread.

If this is not a valid option, we may need to predict the way we display longer comments (with view full comment hint) and use the add comment section (maybe with scroll), but this is something I'd suggest avoid.

@satazor @marcooliveira @diasdavid

@marcooliveira
Copy link
Member

I'd suggest keeping it simple for the time being, limiting the size of the comments to something like 1000 characters, which is already quite big. Then, on a second iteration, we allow bigger than 1000, but warn the user that "Part of the message will be hidden", and we truncate the message around 1000 chars, with a "more..." to expand.

@satazor
Copy link
Contributor

satazor commented Oct 26, 2018

@marcooliveira That's might thoughts exactly, I would do go for the later long term and, for now, implement a simple 1000 chars limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants