Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop inline javascript #429

Open
chris34 opened this issue Dec 19, 2020 · 1 comment
Open

Drop inline javascript #429

chris34 opened this issue Dec 19, 2020 · 1 comment
Labels
general javascript Pull requests that update Javascript code security

Comments

@chris34
Copy link
Member

chris34 commented Dec 19, 2020

Sometimes these theme uses some inline JavaScript with <script>. It has to be investigated, whether this can be replace with JSON or classes in HTML. Latter can then be used to identify elements in JavaScript and attach f.e. further HTML-elements to it.

This would also allow a more hardened CSP policy.

@chris34 chris34 added security general javascript Pull requests that update Javascript code labels Dec 19, 2020
@KaiserBarbarossa
Copy link
Member

Following files contain inline javascript:

inyoka_theme_ubuntuusers/templates/forum/edit.html
inyoka_theme_ubuntuusers/templates/forum/index.html
inyoka_theme_ubuntuusers/templates/ikhaya/article_edit.html
inyoka_theme_ubuntuusers/templates/ikhaya/detail.html
inyoka_theme_ubuntuusers/templates/ikhaya/event_edit.html
inyoka_theme_ubuntuusers/templates/ikhaya/event_suggest.html
inyoka_theme_ubuntuusers/templates/ikhaya/page.html
inyoka_theme_ubuntuusers/templates/ikhaya/report_new.html
inyoka_theme_ubuntuusers/templates/ikhaya/reports.html
inyoka_theme_ubuntuusers/templates/ikhaya/suggest_new.html
inyoka_theme_ubuntuusers/templates/planet/page.html
inyoka_theme_ubuntuusers/templates/portal/privmsg/index.html
inyoka_theme_ubuntuusers/templates/portal/privmsg/new.html
inyoka_theme_ubuntuusers/templates/portal/usercp/profile.html
inyoka_theme_ubuntuusers/templates/portal/usercp/subscriptions.html
inyoka_theme_ubuntuusers/templates/portal/configuration.html
inyoka_theme_ubuntuusers/templates/portal/login.html
inyoka_theme_ubuntuusers/templates/portal/register.html
inyoka_theme_ubuntuusers/templates/portal/set_new_password.html
inyoka_theme_ubuntuusers/templates/wiki/action_attach.html
inyoka_theme_ubuntuusers/templates/wiki/action_attach_edit.html
inyoka_theme_ubuntuusers/templates/wiki/action_edit.html
inyoka_theme_ubuntuusers/templates/overall.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general javascript Pull requests that update Javascript code security
Projects
None yet
Development

No branches or pull requests

2 participants