Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SPM support #264

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added SPM support #264

wants to merge 5 commits into from

Conversation

calebkleveter
Copy link

Issue Link #172

Closes #172

Goals of this PR 🎉

Adds support for the Swift Package Manager, as an alternative to CocoaPods.

How Has This Been Tested 🔍

Adds a single test CardPartImageViewTests.testAssetResources to check that resources are properly loaded in an SPM environment.

Test Configuration 👾

  • Xcode version: 12.0 (12A7209)
  • Device/Simulator: N/A
  • iOS version: N/A

Things to check on 🎯

  • My Pull Request code follows the coding standards and styles of the project
  • I have worked on unit tests and reviewed my code to the best of my ability
  • I have used comments to make other coders understand my code better
  • My changes are good to go without any warnings
  • I have added unit tests both for the happy and sad path
  • All of my unit tests pass successfully before pushing the PR
  • I have made sure all dependent downstream changes impacted by my PR are working

@calebkleveter
Copy link
Author

I am getting this warning on all the dependency modules (RxSwift, RxRelay, RxCocoaRuntime, RxCocoa, Differentiator, and RxDataSource).

The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99.

I don't know if there is a good way to fix this, but I am looking.

@calebkleveter
Copy link
Author

The warnings are apparently caused by Xcode 12 dropping support for iOS 8. This means that the warnings that this PR introduces are caused by the dependencies, not the package itself. Separate PRs would have to be submitted to the dependency repos to increase their minimum iOS version to 9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swift Package Manager
1 participant
@calebkleveter