-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PGPy/sectxt parser #1453
Labels
bug
Unexpected or unwanted behaviour of current implementations
release blocker
Issues that must be resolved before an upcoming version can be released
Milestone
Comments
bwbroersma
added
bug
Unexpected or unwanted behaviour of current implementations
release blocker
Issues that must be resolved before an upcoming version can be released
labels
Jul 7, 2024
@mxsasha I agree with the 'is this guaranteed to work' question in regards to only patch PGPy in the requirements of internet.nl, and still having a different PGPy version as sub-dependency of sectxt. I could not find it, so it might be quirky behavior indeed. Better wait for the DTC patch, or pin to the sectxt PR (and then as a result also the PGPy PR). |
mxsasha
added a commit
that referenced
this issue
Jul 15, 2024
We depend on SecurityInnovation/PGPy#467 and sectxt's pypi release can not point to that, only to other pypi releases. Hence, pull sectxt from github now.
mxsasha
added a commit
that referenced
this issue
Jul 15, 2024
We depend on SecurityInnovation/PGPy#467 and sectxt's pypi release can not point to that, only to other pypi releases. Hence, pull sectxt from github now.
mxsasha
added a commit
that referenced
this issue
Jul 16, 2024
mxsasha
added a commit
that referenced
this issue
Jul 16, 2024
mxsasha
added a commit
that referenced
this issue
Jul 24, 2024
We depend on SecurityInnovation/PGPy#467 and sectxt's pypi release can not point to that, only to other pypi releases. Hence, pull sectxt from github now. (cherry picked from commit abc6742)
mxsasha
added a commit
that referenced
this issue
Aug 12, 2024
We depend on SecurityInnovation/PGPy#467 and sectxt's pypi release can not point to that, only to other pypi releases. Hence, pull sectxt from github now. (cherry picked from commit abc6742)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Unexpected or unwanted behaviour of current implementations
release blocker
Issues that must be resolved before an upcoming version can be released
This is solved by either pinning sectxt to PR:
Or pinning PGPy to PR:
So the required PGPy will be:
Then this probe will run without hanging on the malformed PGP armor (
------
):$ docker exec -ti internetnl-develop-app-1 python3 manage.py probe --probe=appsecpriv_web_appsecpriv --domain=www.devolksbank.nl
The text was updated successfully, but these errors were encountered: