Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI improvement] Centre the "To adjust your budget" text on landing page #722

Closed
tselit opened this issue Nov 21, 2024 · 16 comments · Fixed by #725
Closed

[UI improvement] Centre the "To adjust your budget" text on landing page #722

tselit opened this issue Nov 21, 2024 · 16 comments · Fixed by #725
Assignees
Labels
area: popup Improvements or additions to extension popup good first issue Good for newcomers UX improvements

Comments

@tselit
Copy link
Contributor

tselit commented Nov 21, 2024

Describe the feature you would like to request

Currently, the extension's landing page shows the following text right-aligned:
To adjust your budget or rate of pay, click on ⚙️

This is a minor UI improvement request to centre the text.

Describe the solution you would like

On the extension's landing page, use centred alignment for the following text, with its gear icon: To adjust your budget or rate of pay, click on ⚙️

Additional context

Here is the design in Figma:
https://www.figma.com/design/0S8Oj8ZB5MvkGtIrVRswDH/Web-Monetization?node-id=872-502&t=oYNtzfTANF8253cL-4

@tselit tselit added good first issue Good for newcomers area: popup Improvements or additions to extension popup UX improvements labels Nov 21, 2024
@tselit tselit added this to the Public Beta release milestone Nov 21, 2024
@arashveysi3
Copy link
Contributor

working on it. leave it to me plzz

@arashveysi3
Copy link
Contributor

having serious problems with creating a test wallet. I can't get verified...

@sidvishnoi
Copy link
Member

Hi @arashveysi3, do you mean you are facing difficulties getting verified at https://wallet.interledger-test.dev/? If so, can you trying refreshing page? If that fails, please clear cookies and storage (or open in new private window) and try signing up/logging in again.

@sidvishnoi
Copy link
Member

FWIW, I'm writing a developer's guide for the extension, and will also include test wallet information there. It should be available by tomorrow.

@arashveysi3
Copy link
Contributor

Hey @sidvishnoi Thanks for getting back to me
Yes I did that too. but still can't get verified at https://wallet.interledger-test.dev/
if so, I will wait till tomorrow for test wallet information or you can share the info with me today :)

@sidvishnoi
Copy link
Member

@arashveysi3 Does it keep sending you to KYC page over and over even after completion? Please do try logging in a separate private window (sometimes there's stray cookies in test wallet).

@arashveysi3
Copy link
Contributor

@arashveysi3 Does it keep sending you to KYC page over and over even after completion? Please do try logging in a separate private window (sometimes there's stray cookies in test wallet).

After completion of registration when I get back it says I have to resubmit my docs.
Used my phone and another device but still same thing happens

@Tymmmy
Copy link

Tymmmy commented Nov 22, 2024

@arashveysi3 what is the email you used for signup?

@arashveysi3
Copy link
Contributor

@arashveysi3 what is the email you used for signup?

[email protected]

@arashveysi3
Copy link
Contributor

I checked again and it's fixed now!
Okey back to my task :)

@arashveysi3
Copy link
Contributor

@sidvishnoi another question,
how can I get to the page which you needed to be fixed?

the only page I have is:

Screenshot (11)

anddd of course I tried interledger Boutique, still it says this website is not monetized

@sidvishnoi
Copy link
Member

sidvishnoi commented Nov 22, 2024

@arashveysi3 You need to be on a monetized website to see the other screen. You can visit this simple WM test on my website, or try more customizable behavior by adding wallet addresses to Web Monetization Playground.

@sidvishnoi
Copy link
Member

You'd need to update src/popup/pages/Home.tsx

arashveysi3 added a commit to arashveysi3/web-monetization-extension that referenced this issue Nov 22, 2024
@arashveysi3
Copy link
Contributor

Got it! fixed please review and let me know if any improvements needed.
hope it helps!

@sidvishnoi
Copy link
Member

@arashveysi3 don't forget to send PR 😄

@arashveysi3
Copy link
Contributor

@arashveysi3 don't forget to send PR 😄

Sorry
Thought I did before and we are on PR page conversation. 😂😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: popup Improvements or additions to extension popup good first issue Good for newcomers UX improvements
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants