Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Setup]: Show auto-key add notification to user #622

Closed
Tracked by #613
sidvishnoi opened this issue Sep 24, 2024 · 2 comments · Fixed by #634
Closed
Tracked by #613

[Setup]: Show auto-key add notification to user #622

sidvishnoi opened this issue Sep 24, 2024 · 2 comments · Fixed by #634

Comments

@sidvishnoi
Copy link
Member

sidvishnoi commented Sep 24, 2024

Show a notification UI on wallet page when adding public key to wallet, to inform user of progress or failure; and not cause confusion or intimidate user as we're controlling the browser.

Part of #613

@sidvishnoi
Copy link
Member Author

cc: @RabebOthmani

@sidvishnoi
Copy link
Member Author

sidvishnoi commented Sep 25, 2024

Had a discussion with @RabebOthmani today. We are inclined towards:

  • Adding a consent screen before starting page takeover to add key (filed #625)
  • Overlaying the page (instead of a notifcation) with a "full screen progress spinner screen" so user isn't intimidated by things clicks and navigation happening without their direct action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant