Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle iframe permission policy (allow attribute) #575

Open
sidvishnoi opened this issue Sep 6, 2024 · 0 comments
Open

Correctly handle iframe permission policy (allow attribute) #575

sidvishnoi opened this issue Sep 6, 2024 · 0 comments
Labels
area: content Improvements or additions to extension content script bug Something isn't working good first issue Good for newcomers hacktoberfest Issues for Hacktoberfest
Milestone

Comments

@sidvishnoi
Copy link
Member

  • Presently only checks if allow === "monetization", which breaks if other directives are present.
  • Should also handle monetization directive's allowlist correctly, specially the "<origin>" type.

Spec: https://webmonetization.org/specification/#permissions-policy
MDN: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Permissions-Policy#iframes

@sidvishnoi sidvishnoi added the bug Something isn't working label Sep 6, 2024
@sidvishnoi sidvishnoi added the good first issue Good for newcomers label Oct 9, 2024
@raducristianpopa raducristianpopa added the hacktoberfest Issues for Hacktoberfest label Oct 14, 2024
@sidvishnoi sidvishnoi added the area: content Improvements or additions to extension content script label Nov 13, 2024
@RabebOthmani RabebOthmani added this to the V0.5 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: content Improvements or additions to extension content script bug Something isn't working good first issue Good for newcomers hacktoberfest Issues for Hacktoberfest
Projects
Status: Backlog
Development

No branches or pull requests

3 participants