-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger load
event after checking the wallet address
#43
Comments
In progress: @dianafulga will discuss with Radu (25 Jan) before in order to update the estimated effort. |
Missing a clear definition of the "verification of the monetization link". Currently the verification code is spread across multiple files and moments in the user flow like so:
According to the specs, if the verification fails, we should emit an error event, but currently is not implemented at every step during all the steps mentioned above, to be decided if and where we want to implement it |
The ticket will considered solved with the current PR as the load event has been moved to be triggered after a session has been established. |
At the moment, the
load
event is triggered automatically when the WM polyfill is injected which is not the intended behaviour. Themonetization
link should be checked before triggering theload
event - spec.document_start
(beforewindow.onload
) (--- from Allow checking for WM support before window's load event #78 , implemented here)The text was updated successfully, but these errors were encountered: