Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger load event after checking the wallet address #43

Closed
raducristianpopa opened this issue Dec 11, 2023 · 3 comments · Fixed by #97
Closed

Trigger load event after checking the wallet address #43

raducristianpopa opened this issue Dec 11, 2023 · 3 comments · Fixed by #97
Assignees
Labels
enhancement New feature or request

Comments

@raducristianpopa
Copy link
Member

raducristianpopa commented Dec 11, 2023

At the moment, the load event is triggered automatically when the WM polyfill is injected which is not the intended behaviour. The monetization link should be checked before triggering the load event - spec.

@raducristianpopa raducristianpopa added the enhancement New feature or request label Dec 11, 2023
@raducristianpopa raducristianpopa moved this from Backlog to Todo in Web Monetization Extension Jan 16, 2024
@dianafulga dianafulga self-assigned this Jan 23, 2024
@dianafulga dianafulga moved this from Todo to In Progress in Web Monetization Extension Jan 23, 2024
@tselit
Copy link
Contributor

tselit commented Jan 24, 2024

In progress: @dianafulga will discuss with Radu (25 Jan) before in order to update the estimated effort.

@dianafulga dianafulga moved this from In Progress to In Review in Web Monetization Extension Feb 12, 2024
@dianafulga dianafulga moved this from In Review to Done in Web Monetization Extension Feb 12, 2024
@dianafulga dianafulga moved this from Done to In Review in Web Monetization Extension Feb 12, 2024
@dianafulga dianafulga linked a pull request Feb 13, 2024 that will close this issue
@dianafulga
Copy link
Contributor

dianafulga commented Feb 15, 2024

Missing a clear definition of the "verification of the monetization link". Currently the verification code is spread across multiple files and moments in the user flow like so:

  • if WM is disabled in the extension (not yet implemented - TBD in the new flow), time: to be decided, location: to be decided (if WM disabled, don't proceed to other checks)
  • if valid format for a link (ex: having http/https protocol), time: when opening a new page, location: TabManager
  • if link tag in page, time: when opening a new page, location: background
  • establish session (which qualifies as verification according to the specs), time: when user clicks on connect (to be changed with the new flow), location: background

According to the specs, if the verification fails, we should emit an error event, but currently is not implemented at every step during all the steps mentioned above, to be decided if and where we want to implement it

@dianafulga
Copy link
Contributor

dianafulga commented Feb 15, 2024

The ticket will considered solved with the current PR as the load event has been moved to be triggered after a session has been established.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants