Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable / disable continuous payments #238

Closed
tselit opened this issue Apr 29, 2024 · 3 comments · Fixed by #271
Closed

Enable / disable continuous payments #238

tselit opened this issue Apr 29, 2024 · 3 comments · Fixed by #271
Assignees
Labels
area: popup Improvements or additions to extension popup

Comments

@tselit
Copy link
Contributor

tselit commented Apr 29, 2024

When the extension is connected to a wallet:

  1. A user can enable the extension to make continuous WM payments to any website by setting the toggle like this, this will apply the configured hourly rate of WM payments:
    Image

  2. A user can disable the extension from making any continuous WM payments to all WM websites by setting the toggle like this:
    Image

@tselit tselit converted this from a draft issue Apr 29, 2024
@tselit tselit added this to the WM extension 1.0.0-alpha milestone Apr 29, 2024
@tselit tselit added the area: popup Improvements or additions to extension popup label Apr 29, 2024
@dianafulga dianafulga moved this from Todo to In Progress in Web Monetization Extension May 9, 2024
@tselit
Copy link
Contributor Author

tselit commented May 9, 2024

We have been discussing a possible issue: what is the difference or relationship between the functionality of enable/disable continuous payments compared to the functionality of enable/disable WM globally.

One of the questions is: does this enable/disable continuous payments apply only the current website or does it apply to any website I visit? (probably not a right/wrong way, just an implementation decision for us to make)

Current decision for the alpha release: disable continuous payments will apply to any website that the user visits, and so it does not only apply to the current website.

@dianafulga dianafulga moved this from In Progress to In Review in Web Monetization Extension May 10, 2024
@dianafulga dianafulga linked a pull request May 10, 2024 that will close this issue
@tselit
Copy link
Contributor Author

tselit commented May 14, 2024

Agreed to put this ticket on-hold until we (or Tseli) have a full conversation with Alex about what the distinction is between en/disabling WM globally or the use of continuous payments when the Exceptions List functionality is implemented.

@tselit tselit moved this from In Review to Blocked in Web Monetization Extension May 14, 2024
@tselit
Copy link
Contributor Author

tselit commented May 14, 2024

Issue unblocked by decision agreed with Alex today (14 May):

  • We realized that there is no difference between the intended way that the global WM en/disable toggle works, and how the "continuous payments" toggle is supposed to work.
  • Decision: hide the global enable/disable toggle (because it duplicates the intended behaviour of the continuous payments toggle).
  • Decision: the "continuous payments" toggle should implement the functionality that had been implemented for Handle globally en/disabled WM #61 (i.e. the way we handled the global enable/disable WM toggle).

Here is the updated UI:
image

@tselit tselit moved this from Blocked to Todo in Web Monetization Extension May 14, 2024
@dianafulga dianafulga moved this from Todo to In Progress in Web Monetization Extension May 16, 2024
@dianafulga dianafulga moved this from In Progress to In Review in Web Monetization Extension May 16, 2024
@dianafulga dianafulga removed a link to a pull request May 17, 2024
@dianafulga dianafulga linked a pull request May 17, 2024 that will close this issue
@dianafulga dianafulga moved this from In Review to Done in Web Monetization Extension May 17, 2024
@tselit tselit mentioned this issue Jun 4, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: popup Improvements or additions to extension popup
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants