feat: Add user name to transactions list and redesign list #1870
+381
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: wallet/frontend
Tymmmy
requested review from
raducristianpopa,
adrianboros,
beniaminmunteanu,
lengyel-arpad85 and
RaulBR
Tymmmy
commented
Jan 22, 2025
| @@ -44,6 +46,8 @@ const THead = ({ | |||
| key={col} | |||
| className={cx( | |||
| 'border-b border-green dark:border-pink-neon p-4 text-left font-bold', | |||
| hideForMobile?.find((item) => item === col) !== undefined && | |||
There was a problem hiding this comment.
Taking into consideration limited space available, let's hide some fields for mobile. All details can be viewed in the Details Dialog
Tymmmy
commented
Jan 22, 2025
|
|
||
| return ( | ||
| <> | ||
| {showDateHeader ? ( |
There was a problem hiding this comment.
Transaction list reimagined - with a date header - and all transactions listed bellow for that day only, then a new date header and transactions, and so on, something like Revolut.
Also reordered some fields, removed others, all details can be viewed by clicking on the transaction
adrianboros
previously approved these changes
Jan 22, 2025
adrianboros
approved these changes
Jan 27, 2025
raducristianpopa
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes