You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Based on the discussion in #2795, we noticed that Rafiki lets uploading duplicate keys to a wallet address as there is no unique constraints. This might lead to confusing behavior for validating keys.
We should prevent unique keys from being uploaded, particularly by kid, since it needs to be clear which key (and corresponding key value) the Open Payments client is using in their requests.
Todos
Deleting existing duplicate keys: Remove active duplicates, keep the most recent active key
Prevent unique keys from being uploaded by adding a unique constraint on (walletAddressId, kid). We should check for the UniqueConstraintError in the create method to give a proper error message back in the API response
The text was updated successfully, but these errors were encountered:
Context
Based on the discussion in #2795, we noticed that Rafiki lets uploading duplicate keys to a wallet address as there is no unique constraints. This might lead to confusing behavior for validating keys.
We should prevent unique keys from being uploaded, particularly by
kid
, since it needs to be clear which key (and corresponding key value) the Open Payments client is using in their requests.Todos
(walletAddressId, kid)
. We should check for theUniqueConstraintError
in the create method to give a proper error message back in the API responseThe text was updated successfully, but these errors were encountered: