Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managing unique wallet address keys #3130

Open
2 tasks
mkurapov opened this issue Nov 25, 2024 · 0 comments · May be fixed by #2863
Open
2 tasks

Managing unique wallet address keys #3130

mkurapov opened this issue Nov 25, 2024 · 0 comments · May be fixed by #2863
Assignees

Comments

@mkurapov
Copy link
Contributor

Context

Based on the discussion in #2795, we noticed that Rafiki lets uploading duplicate keys to a wallet address as there is no unique constraints. This might lead to confusing behavior for validating keys.

We should prevent unique keys from being uploaded, particularly by kid, since it needs to be clear which key (and corresponding key value) the Open Payments client is using in their requests.

Todos

  • Deleting existing duplicate keys: Remove active duplicates, keep the most recent active key
  • Prevent unique keys from being uploaded by adding a unique constraint on (walletAddressId, kid). We should check for the UniqueConstraintError in the create method to give a proper error message back in the API response
@github-project-automation github-project-automation bot moved this to Backlog in Rafiki Nov 25, 2024
@mkurapov mkurapov linked a pull request Nov 25, 2024 that will close this issue
5 tasks
@oana-lolea oana-lolea linked a pull request Nov 27, 2024 that will close this issue
5 tasks
@oana-lolea oana-lolea moved this from In Progress to Ready for Review in Rafiki Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Review
Development

Successfully merging a pull request may close this issue.

2 participants