Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multi-Tenant] Tenanted Incoming Payments #3117

Open
5 tasks
Tracked by #2893
njlie opened this issue Nov 21, 2024 · 0 comments
Open
5 tasks
Tracked by #2893

[Multi-Tenant] Tenanted Incoming Payments #3117

njlie opened this issue Nov 21, 2024 · 0 comments
Assignees
Labels
pkg: backend Changes in the backend package.

Comments

@njlie
Copy link
Contributor

njlie commented Nov 21, 2024

Incoming Payments should become tenanted as per the Multi-Tenancy design, and will be logically separated in the backend database by a tenantId row that serves as a foreign key on the tenants table.

  • Add tenantId row to incomingPayments table that is required and maps to an id on the tenants table.
  • Add tenantId to database queries on incoming payments
  • Acquire tenantId from request headers on routes involving incoming payments and pass them into incoming payment service logic.
  • Include tenantId in path of incoming payment URL. e.g. http://exampe-rafiki/:tenantId/incoming-payments/:id
  • Additionally, we should be able to support fetching an incoming payment with and without tenant id:
    • for GraphQL Admin API requests to get (and update) an incoming payment, tenantId will be provided in those requests, and it should be used when getting (or updating) the incoming payments.
    • However, because we are able to make payments across tenanted resources (ie. an outgoing payment on tenant A can pay into an incoming payment on tenant B), we should also have the functionality to to look up the incoming payment just by the Id, tenant-agnostic

Prerequisites

@njlie njlie added the pkg: backend Changes in the backend package. label Nov 21, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Rafiki Nov 21, 2024
@njlie njlie moved this from Backlog to Todo in Rafiki Nov 25, 2024
@oana-lolea oana-lolea moved this from Todo to In Progress in Rafiki Nov 27, 2024
@golobitch golobitch added this to the Multi Tenant v1 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: backend Changes in the backend package.
Projects
Status: In Progress
Development

No branches or pull requests

3 participants