Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularization? #3

Open
mmalecki opened this issue Jun 2, 2024 · 1 comment
Open

Modularization? #3

mmalecki opened this issue Jun 2, 2024 · 1 comment

Comments

@mmalecki
Copy link

mmalecki commented Jun 2, 2024

Hello,

Firstly, thanks for this module. It indeed reduced time to market (time I spent swearing) and enabled stakeholders (me) to focus on developing business synergy (finding cool people to follow).

Secondly, the name of the game when it comes to sharing Terraform code appears to be modules. These assume no external dependencies, like terraform_remote_state, etc. I've modularized these workspaces to make them work with my IaC automation (Terragrunt), so instead of changing terraform.tfvars, my invocation and configuration looks sort of like this:

module "mastodon" {
  source = "./../../modules/mastodon-gcp/mastodon"

  project = data.terraform_remote_state.org_structure.outputs.service_project_ids.social

  create_admin = false

  local_domain = "mmalecki.com"
  web_domain   = var.mastodon_domain_name

  smtp_from_address        = "mastodon@${var.mastodon_domain_name}"
  smtp_domain              = var.mastodon_domain_name
  # ...etc, etc.
}

My question is, would you be open to accepting a PR to make this codebase work like this, or do you like it the way it is :) ?

@jeremiahlee
Copy link
Collaborator

I apologize for not seeing this until now. I would enthusiastically accept a PR to make the codebase work like this. It was on my "next version" to-do list after just getting it functioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants